-
-
Notifications
You must be signed in to change notification settings - Fork 398
Add macro during lib discovery phase #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add macro during lib discovery phase #633
Conversation
This information can be used by the core to turn off certain heavyweight headers (that don't need to be discovered anyway)
- Removed automatic '--relax' hack for compiles on Atmega2560 MCU arduino/arduino-cli#749 - Fixed skethbook+bootloader hex merger. arduino/arduino-cli#744 - Fixed race condition in legacy i18n.LoggerToCustomStreams arduino/arduino-cli#704 - Fixed path-relativization error when traversing different partitions arduino/arduino-cli#658 - Add macro during lib discovery phase arduino/arduino-cli#633 - legacy: Improved progress report from Compile arduino/arduino-cli#625
Hi @facchinm when you said it can be used, how ? In fact we've met an issue since this has been added. It add an extra definition at the end of the command line but the compiler used doesn't understand it (https://github.com/stm32duino/Arduino_Core_STM8/issues/21): as for the specific cosmic compiler used for the STM8 core "-D" is replaced by "-d" Is it possible to avoid to add extra arguments? Thanks in advance |
hi @fpistm I didn't know that the STM8 compiler use The definition BTW let's fix this, I'll open a new issue with a proposal. |
Hi @cmaglie |
…phase (arduino#633)" This reverts commit 985b2c9.
Previously we used to add `-DARDUINO_LIB_DISCOVERY_PHASE` to the gcc command line but this produced some incompatiblity with compilers using non-standard `-d` flag instead of `-D`: arduino#633 (comment)
…me rare circumstances (#838) * Revert "Add macro -DARDUINO_LIB_DISCOVERY_PHASE during lib discovery phase (#633)" This reverts commit 985b2c9. * Set {build.library_discovery_phase} to 1 during lib discovery Previously we used to add `-DARDUINO_LIB_DISCOVERY_PHASE` to the gcc command line but this produced some incompatiblity with compilers using non-standard `-d` flag instead of `-D`: #633 (comment)
This information can be used by the core to turn off certain heavyweight headers (that don't need to be discovered anyway)